A few patches against SVN

Post new topic Reply to topic  [ 12 posts ] 
Author Message
 Post subject: A few patches against SVN
PostPosted: Mon Jan 05, 2009 6:55 am 
User avatar
Burned to a crisp

Current Scorched3D Rank: Unranked





Joined: Sun Sep 03, 2006 11:08 am
Posts: 268
Location: Latvia
So sometimes somebody comes up with a neat idea that seems like it would be pretty easy to add, except nobody's doing it. One such idea was the ability to sort items by price in the buy window. These last few days I didn't really have anything else to do, so I spent them digging through the code, and now I've got a few patches prepared against the latest code in SVN, one of which adds that ability. I've published them as a Git repo at http://repo.or.cz/w/scorched3d/parasti.git, but I'm also posting links to the raw patches that can probably be fed to "patch -p1 < file.patch":

GCC 4.3 compatibility (old problem, apparently still not fixed)
Extend accessory sorting to allow sorting by price (applied)

I suppose I should mention this is pretty much my first experience with C++ specifically and Scorched3D source code, so be prepared that this code might make you (or your computer) want to throw up a bit.


Attachments:
sort-by-price-hogger.png
sort-by-price-hogger.png [ 108.68 KiB | Viewed 2896 times ]


Last edited by parasti on Sun Jan 11, 2009 7:59 pm, edited 1 time in total.
Top
 Profile  
 
 Post subject: Re: A few patches against SVN
PostPosted: Mon Jan 05, 2009 7:56 am 
User avatar
Obliterated

Current Scorched3D Rank: Unranked




Joined: Wed Aug 15, 2007 11:20 am
Posts: 1694
Location: At my home in Herrlingen, Germany. Recovering from another assassination attempt.
Hi Parasti:

Nice job!

It's really great to see a submission. I remain hopeful.

The spirit of open source lives!

Best wishes,

Rommel
Nothing gives one person so much advantage over another as to remain
always cool and unruffled under all circumstances. - Thomas Jefferson

You can discover more about a person in an hour of play
than in a year of conversation. - Plato


Last edited by Rommel on Mon Jan 05, 2009 8:28 am, edited 1 time in total.

Top
 Profile  
 
 Post subject: Re: A few patches against SVN
PostPosted: Mon Jan 05, 2009 8:18 am 
User avatar
Obliterated

Current Scorched3D Rank: Unranked






Joined: Sat Nov 05, 2005 9:29 am
Posts: 1958
Location: In a Rental.
It shouldn't be too much trouble for him to pop this into the source in progress.

Rather than have players try to patch it themselves, it's always best if
the game comes with all these features off the shelf. That way it's easier
to support them when they find a bug.


Thanks Parasti, I'd been mulling over whether to add that to mine manually, or
have gavin add it. He's getting close to cutting off the line of changes soon,
in order to consider a workable beta before we all grow ZZ-Top beards.
Scorched3D Mod-Servers
Forum
Stats
Mods-Page


Top
 Profile  
 
 Post subject: Re: A few patches against SVN
PostPosted: Mon Jan 05, 2009 9:22 pm 
User avatar
Burned to a crisp

Current Scorched3D Rank: Unranked





Joined: Sun Sep 03, 2006 11:08 am
Posts: 268
Location: Latvia
Thrax wrote:
It shouldn't be too much trouble for him to pop this into the source in progress.

Yeah, that's actually why I used the SVN code rather than 41.3. I honestly don't expect anybody to commit the unmodified patch to the repo in a heartbeat, but I hope it's enough to at least get the ball rolling, one way or another.


Top
 Profile  
 
 Post subject: Re: A few patches against SVN
PostPosted: Thu Jan 08, 2009 3:19 am 
User avatar
Site Admin
Not Signed Up For Stats

Joined: Mon Aug 04, 2003 4:09 pm
Posts: 4785
Location: Scotland
Thanks Dude looks like some good work, I'll add it to the repository when I get into work tomorrow (my memory allowing :) ).


Top
 Profile  
 
 Post subject: Re: A few patches against SVN
PostPosted: Thu Jan 08, 2009 7:11 am 
User avatar
Reduced to ashes

Current Scorched3D Rank: 20






Joined: Sat Jun 03, 2006 4:13 am
Posts: 720
Funny I had just menitoned to Thrax the other day that sort by price would be an awesome feature!
Not an addict just can't stop
Image


Top
 Profile  
 
 Post subject: Re: A few patches against SVN
PostPosted: Thu Jan 08, 2009 9:19 am 
User avatar
Obliterated

Current Scorched3D Rank: Unranked






Joined: Sat Nov 05, 2005 9:29 am
Posts: 1958
Location: In a Rental.
pastor of muppets wrote:
Funny I had just menitoned to Thrax the other day that
sort by price would be an awesome feature!

It's been mentioned and discussed a few times over the year.. just nothing
done about it due to lack of importance.

Not all servers would have a need for that, since the weapons only take up
a short scroll-bar.. But for those that do, it is very handy indeed.
Scorched3D Mod-Servers
Forum
Stats
Mods-Page


Top
 Profile  
 
 Post subject: Re: A few patches against SVN
PostPosted: Fri Jan 09, 2009 3:38 pm 
User avatar
Burned to a crisp

Current Scorched3D Rank: Unranked





Joined: Sun Sep 03, 2006 11:08 am
Posts: 268
Location: Latvia
gcamp wrote:
Thanks Dude looks like some good work, I'll add it to the repository when I get into work tomorrow (my memory allowing :) ).

That's great. I'll let you know when it starts to feel like nothing is happening.


Top
 Profile  
 
 Post subject: Re: A few patches against SVN
PostPosted: Sun Jan 11, 2009 8:02 pm 
User avatar
Burned to a crisp

Current Scorched3D Rank: Unranked





Joined: Sun Sep 03, 2006 11:08 am
Posts: 268
Location: Latvia
I see the sort-by-price patch has been committed to the repo. I've updated the top post accordingly. Thanks!


Top
 Profile  
 
 Post subject: Re: A few patches against SVN
PostPosted: Thu Jan 15, 2009 4:58 pm 
User avatar
Site Admin
Not Signed Up For Stats

Joined: Mon Aug 04, 2003 4:09 pm
Posts: 4785
Location: Scotland
Yeah I am not sure about the compiler fix, I'd need to re-test all of the unix/windows compilation and I am not sure I have time for that this release.


Top
 Profile  
 
 Post subject: Re: A few patches against SVN
PostPosted: Thu Jan 15, 2009 5:03 pm 
User avatar
Site Admin
Not Signed Up For Stats

Joined: Mon Aug 04, 2003 4:09 pm
Posts: 4785
Location: Scotland
Oh and the sorting fix was great BTW, didn't need to change a thing after review.


Top
 Profile  
 
 Post subject: Re: A few patches against SVN
PostPosted: Fri Jan 16, 2009 1:46 am 
User avatar
Burned to a crisp

Current Scorched3D Rank: Unranked





Joined: Sun Sep 03, 2006 11:08 am
Posts: 268
Location: Latvia
Glad to read that. As for the GCC 4.3 patch, I'm not particularly confident that I did it the right way, but it only adds a few headers (so no harm done if I messed up somewhere) and the game does fail to compile without it. But I'm sure distro packagers will take care of it even if you decide to hold off until after the release.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 12 posts ] 


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB © phpBB Group